[verified] Clear idle Details state and improve header contrast #32

Merged

astaranix merged 1 commit from astaranix/details-idle-state-and-contrast into main

2026-09-13 20:03:41 -04:00

AGit

astaranix commented

2026-09-13 20:01:46 -04:00

Owner

Fix

Hide retained warning/error totals in Live monitor when no build is active. Completed and failed runs now return to the idle message without leaving a partial live-state summary behind.
Preserve retained output and observer-staleness warnings; active builds still show their diagnostics, phase, item, and progress.
Use the Output follow button's primary colors for enabled, hovered, and pressed header controls. Keep the existing secondary disabled styling and all request-admission gates unchanged.

Verification

Both regressions were observed failing before their fixes: the idle projection reproduced the screenshot's residual warning/error line, and the real Iced renderer demonstrated the header/Output color mismatch.
Default-feature Rust all-target suite: 197 passed, 1 ignored. No-default-feature suite: 80 passed. Both used --locked and --no-fail-fast.
Real tiny-skia widget drawing checks both header controls against Output in light/dark themes and narrow/wide layouts, including hovered/pressed and unchanged disabled styles. All 19 Details unit tests also passed in a separate fontless process.
Built the actual aarch64-linux Rust tray and no-default package tests, plus the lock, Wayland/X11 desktop, and X11 geometry smoke checks. All passed using nixpkgs eaad089433ca2bb662274377d33df3d0e51ef28b without writing a flake lock; realized store outputs and the geometry proof were read back.
Formatting, staged whitespace, added-line security scan, and independent read-only review passed.
Strict Clippy remains non-green on pre-existing warnings. Comparing the full diagnostic identities against an isolated main export found the same 24 distinct diagnostics and no additions or removals.

Scope and limitations

Only Rust Details rendering and its tests changed. Updater commands, privileges, dependencies, request gating, and the legacy C++ tray are unchanged. Retained output is not erased. No system activation or installed-tray restart was performed.

The existing real-nh telemetry replay test remains ignored unless supplied its external build-log fixture; this UI-only follow-up did not rerun that producer probe. X11 geometry was exercised with the packaged screenshot-based smoke; Wayland coverage is startup/lifecycle rather than child-widget geometry.

## Fix - Hide retained warning/error totals in Live monitor when no build is active. Completed and failed runs now return to the idle message without leaving a partial live-state summary behind. - Preserve retained output and observer-staleness warnings; active builds still show their diagnostics, phase, item, and progress. - Use the Output follow button's primary colors for enabled, hovered, and pressed header controls. Keep the existing secondary disabled styling and all request-admission gates unchanged. ## Verification - Both regressions were observed failing before their fixes: the idle projection reproduced the screenshot's residual warning/error line, and the real Iced renderer demonstrated the header/Output color mismatch. - Default-feature Rust all-target suite: 197 passed, 1 ignored. No-default-feature suite: 80 passed. Both used --locked and --no-fail-fast. - Real tiny-skia widget drawing checks both header controls against Output in light/dark themes and narrow/wide layouts, including hovered/pressed and unchanged disabled styles. All 19 Details unit tests also passed in a separate fontless process. - Built the actual aarch64-linux Rust tray and no-default package tests, plus the lock, Wayland/X11 desktop, and X11 geometry smoke checks. All passed using nixpkgs eaad089433ca2bb662274377d33df3d0e51ef28b without writing a flake lock; realized store outputs and the geometry proof were read back. - Formatting, staged whitespace, added-line security scan, and independent read-only review passed. - Strict Clippy remains non-green on pre-existing warnings. Comparing the full diagnostic identities against an isolated main export found the same 24 distinct diagnostics and no additions or removals. ## Scope and limitations Only Rust Details rendering and its tests changed. Updater commands, privileges, dependencies, request gating, and the legacy C++ tray are unchanged. Retained output is not erased. No system activation or installed-tray restart was performed. The existing real-nh telemetry replay test remains ignored unless supplied its external build-log fixture; this UI-only follow-up did not rerun that producer probe. X11 geometry was exercised with the packaged screenshot-based smoke; Wayland coverage is startup/lifecycle rather than child-widget geometry.

astaranix added 1 commit

2026-09-13 20:01:46 -04:00

[verified] Clear idle Details state and improve header contrast b916164d6e

## Fix

- Hide retained warning/error totals in Live monitor when no build is active. Completed and failed runs now return to the idle message without leaving a partial live-state summary behind.
- Preserve retained output and observer-staleness warnings; active builds still show their diagnostics, phase, item, and progress.
- Use the Output follow button's primary colors for enabled, hovered, and pressed header controls. Keep the existing secondary disabled styling and all request-admission gates unchanged.

## Verification

- Both regressions were observed failing before their fixes: the idle projection reproduced the screenshot's residual warning/error line, and the real Iced renderer demonstrated the header/Output color mismatch.
- Default-feature Rust all-target suite: 197 passed, 1 ignored. No-default-feature suite: 80 passed. Both used --locked and --no-fail-fast.
- Real tiny-skia widget drawing checks both header controls against Output in light/dark themes and narrow/wide layouts, including hovered/pressed and unchanged disabled styles. All 19 Details unit tests also passed in a separate fontless process.
- Built the actual aarch64-linux Rust tray and no-default package tests, plus the lock, Wayland/X11 desktop, and X11 geometry smoke checks. All passed using nixpkgs eaad089433ca2bb662274377d33df3d0e51ef28b without writing a flake lock; realized store outputs and the geometry proof were read back.
- Formatting, staged whitespace, added-line security scan, and independent read-only review passed.
- Strict Clippy remains non-green on pre-existing warnings. Comparing the full diagnostic identities against an isolated main export found the same 24 distinct diagnostics and no additions or removals.

## Scope and limitations

astaranix merged commit 5fcc9077f2 into main

2026-09-13 20:03:41 -04:00

astaranix referenced this pull request from a commit

2026-09-13 20:03:43 -04:00

Merge pull request '[verified] Clear idle Details state and improve header contrast' (#32) from astaranix/details-idle-state-and-contrast into main

No reviewers

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

astaranix/nixos-updater!32

No description provided.

Rows
Columns